Messages in this thread | | | Date | Wed, 14 Sep 2022 10:08:39 +0200 | From | Philippe De Muyter <> | Subject | Re: [PATCH 1/1] f2fs: fix to check space of current segment journal |
| |
Hello Wu Bo,
On Wed, Sep 14, 2022 at 12:04:23PM +0800, Wu Bo wrote: > As Philippe De Muyter reported: > https://lore.kernel.org/linux-f2fs-devel/20220913224908.GA25100@172.21.0.10/T/#u > > The warning log showed that when finding a new space for nat the journal > space turned out to be full. This because the journal_rwsem is not > locked before the journal space checking. The journal space may become > full just after we check it. > > Reported-by: Philippe De Muyter <phdm@macq.eu> > Signed-off-by: Wu Bo <bo.wu@vivo.com> > --- > fs/f2fs/node.c | 6 +++--- > fs/f2fs/segment.c | 10 +++++----- > 2 files changed, 8 insertions(+), 8 deletions(-) >
Thank you for your patch.
Unfortunately it does not apply to my 4.1.15 or newer 4.1.y sources, and I do not have the knowledge of f2fs internals to modify your patch myself. E.g. 4.1.y lacks the '.journal' field in the 'struct curseg_info'.
Could you make a version suitable for 4.1.y ?
Best regards
Philippe
| |