lkml.org 
[lkml]   [2022]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 5/5] platform/x86: dell: Add new dell-wmi-ddv driver
Date
[Public]



> -----Original Message-----
> From: Armin Wolf <W_Armin@gmx.de>
> Sent: Tuesday, September 13, 2022 09:41
> To: Randy Dunlap <rdunlap@infradead.org>; hdegoede@redhat.com;
> markgross@kernel.org
> Cc: rafael@kernel.org; lenb@kernel.org; hmh@hmh.eng.br;
> matan@svgalib.org; corentin.chary@gmail.com; jeremy@system76.com;
> productdev@system76.com; platform-driver-x86@vger.kernel.org; linux-
> acpi@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 5/5] platform/x86: dell: Add new dell-wmi-ddv driver
>
> Am 12.09.22 um 23:56 schrieb Randy Dunlap:
>
> > Hi--
> >
> > On 9/12/22 05:53, Armin Wolf wrote:
> >> diff --git a/drivers/platform/x86/dell/Kconfig
> b/drivers/platform/x86/dell/Kconfig
> >> index 25421e061c47..209e63e347e2 100644
> >> --- a/drivers/platform/x86/dell/Kconfig
> >> +++ b/drivers/platform/x86/dell/Kconfig
> >> @@ -189,6 +189,19 @@ config DELL_WMI_DESCRIPTOR
> >> default n
> >> depends on ACPI_WMI
> >>
> >> +config DELL_WMI_DDV
> >> + tristate "Dell WMI sensors Support"
> >> + default m
> > You should (try to) justify default m, otherwise just
> > don't have a default for it.
>
> I have chosen default m since many other Dell platform drivers are being
> default m. Since this driver is not essential for normal operation,
> i will drop default m then.

Actually Dell drivers directory are a bit unique in this regard. There is a special
top level boolean. I would suggest to keep it as is.

Take a look at:
menuconfig X86_PLATFORM_DRIVERS_DELL

>
> Armin Wolf
>
> >> + depends on ACPI_BATTERY
> >> + depends on ACPI_WMI
> >> + help
> >> + This option adds support for WMI-based sensors like
> >> + battery temperature sensors found on some Dell notebooks.
> >> + It also supports reading of the batteries ePPID.
> >> +
> >> + To compile this drivers as a module, choose M here: the module will
> >> + be called dell-wmi-ddv.
\
 
 \ /
  Last update: 2022-09-13 19:22    [W:0.080 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site