lkml.org 
[lkml]   [2022]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 5/5] platform/x86: dell: Add new dell-wmi-ddv driver
From
Date
Am 12.09.22 um 23:56 schrieb Randy Dunlap:

> Hi--
>
> On 9/12/22 05:53, Armin Wolf wrote:
>> diff --git a/drivers/platform/x86/dell/Kconfig b/drivers/platform/x86/dell/Kconfig
>> index 25421e061c47..209e63e347e2 100644
>> --- a/drivers/platform/x86/dell/Kconfig
>> +++ b/drivers/platform/x86/dell/Kconfig
>> @@ -189,6 +189,19 @@ config DELL_WMI_DESCRIPTOR
>> default n
>> depends on ACPI_WMI
>>
>> +config DELL_WMI_DDV
>> + tristate "Dell WMI sensors Support"
>> + default m
> You should (try to) justify default m, otherwise just
> don't have a default for it.

I have chosen default m since many other Dell platform drivers are being
default m. Since this driver is not essential for normal operation,
i will drop default m then.

Armin Wolf

>> + depends on ACPI_BATTERY
>> + depends on ACPI_WMI
>> + help
>> + This option adds support for WMI-based sensors like
>> + battery temperature sensors found on some Dell notebooks.
>> + It also supports reading of the batteries ePPID.
>> +
>> + To compile this drivers as a module, choose M here: the module will
>> + be called dell-wmi-ddv.

\
 
 \ /
  Last update: 2022-09-13 17:58    [W:0.201 / U:0.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site