lkml.org 
[lkml]   [2022]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 5/8] remoteproc: qcom: Add efuse evb selection control
From
On 03/08/2022 17:21, Srinivasa Rao Mandadapu wrote:
> Add efuse evb selection control and enable it for starting ADSP.
>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>

Is the lpass_efuse region used solely by the ADSP or is it shared with
anybody else (e.g. other sound-related devices)? If the latter is true,
then please use syscon for the lpass_efuse region.

> ---
> drivers/remoteproc/qcom_q6v5_adsp.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qcom_q6v5_adsp.c
> index a9fcb5c..201cc21 100644
> --- a/drivers/remoteproc/qcom_q6v5_adsp.c
> +++ b/drivers/remoteproc/qcom_q6v5_adsp.c
> @@ -56,6 +56,7 @@
>
> #define LPASS_BOOT_CORE_START BIT(0)
> #define LPASS_BOOT_CMD_START BIT(0)
> +#define LPASS_EFUSE_Q6SS_EVB_SEL 0x0
>
> struct adsp_pil_data {
> int crash_reason_smem;
> @@ -85,6 +86,7 @@ struct qcom_adsp {
> struct clk_bulk_data *clks;
>
> void __iomem *qdsp6ss_base;
> + void __iomem *lpass_efuse;
>
> struct reset_control *pdc_sync_reset;
> struct reset_control *restart;
> @@ -366,6 +368,9 @@ static int adsp_start(struct rproc *rproc)
> /* Program boot address */
> writel(adsp->mem_phys >> 4, adsp->qdsp6ss_base + RST_EVB_REG);
>
> + if (adsp->lpass_efuse)
> + writel(LPASS_EFUSE_Q6SS_EVB_SEL, adsp->lpass_efuse);
> +
> /* De-assert QDSP6 stop core. QDSP6 will execute after out of reset */
> writel(LPASS_BOOT_CORE_START, adsp->qdsp6ss_base + CORE_START_REG);
>
> @@ -520,6 +525,11 @@ static int adsp_init_mmio(struct qcom_adsp *adsp,
> return PTR_ERR(adsp->qdsp6ss_base);
> }
>
> + adsp->lpass_efuse = devm_platform_ioremap_resource_byname(pdev, "lpass_efuse");
> + if (IS_ERR(adsp->lpass_efuse)) {
> + adsp->lpass_efuse = NULL;
> + dev_dbg(adsp->dev, "failed to map LPASS efuse registers\n");
> + }
> syscon = of_parse_phandle(pdev->dev.of_node, "qcom,halt-regs", 0);
> if (!syscon) {
> dev_err(&pdev->dev, "failed to parse qcom,halt-regs\n");


--
With best wishes
Dmitry

\
 
 \ /
  Last update: 2022-08-06 22:27    [W:0.202 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site