lkml.org 
[lkml]   [2022]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 7/9] dt-bindings: usb: qcom,dwc3: add wakeup-source property
On Sat, Aug 06, 2022 at 08:38:48PM +0530, Manivannan Sadhasivam wrote:
> On Thu, Aug 04, 2022 at 05:09:59PM +0200, Johan Hovold wrote:
> > Add a wakeup-source property to the binding to describe whether the
> > wakeup interrupts can wake the system from suspend.
> >
> > Acked-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
>
> So this is based on the fact that Qcom glue wrapper is supplying the wakeup
> interrupts. But isn't it possible that on other platform, the DWC IP can supply
> wakeup interrupts?

Yeah, possibly, and that's why Rob suggested keeping the 'wakeup-source'
property also in the core node.

> In the driver, the wakeup-source parsing has been moved to the Qcom glue driver.
> But this contradicts with the binding.

That's irrelevant. The core driver does not implement wakeup support. It
was just added as a hack for the Qualcomm driver, and you won't get
wakeup-capability for other platforms by just parsing the property in
the core driver.

When/if wakeup support for such a platform is added, then the core
driver may need to look at the property again.

Johan

\
 
 \ /
  Last update: 2022-08-06 18:42    [W:0.073 / U:0.992 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site