lkml.org 
[lkml]   [2022]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [PATCH] spi: microchip-core: Simplify some error message
Date
On 05/08/2022 22:33, Christophe JAILLET wrote:
> dev_err_probe() already prints the error code in a human readable way, so
> there is no need to duplicate it as a numerical value at the end of the
> message.
>
> Moreover, in the case of devm_clk_get() it would only display '0' because
> 'ret' is know to be 0 at this point.
>
> Fixes: cdeaf3a99a02 ("spi: microchip-core: switch to use dev_err_probe()")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

bah, should have noticed that when I reviewed the switch over...
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks!

> ---
> drivers/spi/spi-microchip-core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-microchip-core.c b/drivers/spi/spi-microchip-core.c
> index ce4385330b19..d352844c798c 100644
> --- a/drivers/spi/spi-microchip-core.c
> +++ b/drivers/spi/spi-microchip-core.c
> @@ -548,12 +548,12 @@ static int mchp_corespi_probe(struct platform_device *pdev)
> IRQF_SHARED, dev_name(&pdev->dev), master);
> if (ret)
> return dev_err_probe(&pdev->dev, ret,
> - "could not request irq: %d\n", ret);
> + "could not request irq\n");
>
> spi->clk = devm_clk_get(&pdev->dev, NULL);
> if (IS_ERR(spi->clk))
> return dev_err_probe(&pdev->dev, PTR_ERR(spi->clk),
> - "could not get clk: %d\n", ret);
> + "could not get clk\n");
>
> ret = clk_prepare_enable(spi->clk);
> if (ret)
\
 
 \ /
  Last update: 2022-08-05 23:52    [W:0.068 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site