lkml.org 
[lkml]   [2022]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[for-linus][PATCH] rv: Unlock on error path in rv_unregister_reactor()


Dan Carpenter (1):
rv: Unlock on error path in rv_unregister_reactor()

----
kernel/trace/rv/rv_reactors.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
---------------------------
commit f1a15b977ff864513133ecb611eb28603d32c1b4
Author: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu Aug 4 17:33:48 2022 +0300

rv: Unlock on error path in rv_unregister_reactor()

Unlock the "rv_interface_lock" mutex before returning.

Link: https://lkml.kernel.org/r/YuvYzNfGMgV+PIhd@kili

Fixes: 04acadcb4453 ("rv: Add runtime reactors interface")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>

diff --git a/kernel/trace/rv/rv_reactors.c b/kernel/trace/rv/rv_reactors.c
index a6522c196382..6aae106695b6 100644
--- a/kernel/trace/rv/rv_reactors.c
+++ b/kernel/trace/rv/rv_reactors.c
@@ -329,6 +329,7 @@ int rv_register_reactor(struct rv_reactor *reactor)
int rv_unregister_reactor(struct rv_reactor *reactor)
{
struct rv_reactor_def *ptr, *next;
+ int ret = 0;

mutex_lock(&rv_interface_lock);

@@ -343,13 +344,14 @@ int rv_unregister_reactor(struct rv_reactor *reactor)
ptr->reactor->name, ptr->counter);
printk(KERN_WARNING "rv: the rv_reactor %s cannot be removed\n",
ptr->reactor->name);
- return -EBUSY;
+ ret = -EBUSY;
+ break;
}
}
}

mutex_unlock(&rv_interface_lock);
- return 0;
+ return ret;
}

/*
\
 
 \ /
  Last update: 2022-08-05 17:08    [W:0.027 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site