lkml.org 
[lkml]   [2022]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 09/20] dt-bindings: PCI: dwc: Add interrupts/interrupt-names common properties
    On Mon, Aug 22, 2022 at 09:46:50PM +0300, Serge Semin wrote:
    > Currently the 'interrupts' and 'interrupt-names' are defined being too
    > generic to really describe any actual IRQ interface. Moreover the DW PCIe
    > End-point devices are left with no IRQ signals. All of that can be fixed
    > by adding the IRQ-related properties to the common DW PCIe DT-schema and
    > defining a common and device-specific set of the IRQ names in accordance
    > with the hardware reference manual. Seeing there are common and dedicated
    > IRQ signals for DW PCIe Root Port and End-point controllers we suggest to
    > split the IRQ names up into two sets: common definitions available in the
    > snps,dw-pcie-common.yaml schema and Root Port specific names defined in
    > the snps,dw-pcie.yaml schema. The former one will be applied to both DW
    > PCIe RP and EP controllers, while the later one - for the RP only.
    >
    > Note since there are DW PCI-based vendor-specific DT-bindings with the
    > custom names assigned to the same IRQ resources we have no much choice but
    > to add them to the generic DT-schemas in order to have the schemas being
    > applicable for such devices. Let's mark these names as deprecated so not
    > to encourage the new DT-bindings to use them.
    >
    > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
    >
    > ---
    >
    > Changelog v3:
    > - This is a new patch unpinned from the next one:
    > https://lore.kernel.org/linux-pci/20220503214638.1895-2-Sergey.Semin@baikalelectronics.ru/
    > by the Rob' request. (@Rob)
    >
    > Changelog v5:
    > - Add platform-specific interrupt names, but mark them as deprecated.
    > ---
    > .../bindings/pci/snps,dw-pcie-common.yaml | 51 ++++++++++++++
    > .../bindings/pci/snps,dw-pcie-ep.yaml | 17 +++++
    > .../devicetree/bindings/pci/snps,dw-pcie.yaml | 67 ++++++++++++++++++-
    > 3 files changed, 132 insertions(+), 3 deletions(-)

    I still don't like how you've done interrupts/clocks/reg. I'd suggest
    dropping it if you want this series applied soonish.

    Rob

    \
     
     \ /
      Last update: 2022-08-31 23:25    [W:4.164 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site