Messages in this thread | | | From | Andy Shevchenko <> | Date | Wed, 31 Aug 2022 23:54:45 +0300 | Subject | Re: [PATCH 3/5] gpio: pca953x: Fix pca953x_gpio_set_pull_up_down() |
| |
On Mon, Aug 29, 2022 at 4:43 PM Martyn Welch <martyn.welch@collabora.com> wrote: > > A previous fix (dc87f6dd058a gpio: pca953x: Fix pca953x_gpio_set_config)
Format is wrong. Please read documentation on how to refer to the commits in the tree.
> identified that pinconf_to_config_param() needed to be used to isolate > the config_param from the pinconf in pca953x_gpio_set_config(). This fix > however did not consider that this would also be needed in > pca953x_gpio_set_pull_up_down() to which it passes this config. > > Perform a similar call in pca953x_gpio_set_pull_up_down() to isolate the > configuration parameter there as well, rather than passing it from > pca953x_gpio_set_config() as the configuration argument may also be needed > in pca953x_gpio_set_pull_up_down() at a later date.
...
> u8 pull_en_reg = pca953x_recalc_addr(chip, PCAL953X_PULL_EN, offset); > u8 pull_sel_reg = pca953x_recalc_addr(chip, PCAL953X_PULL_SEL, offset); > u8 bit = BIT(offset % BANK_SZ);
> + enum pin_config_param param = pinconf_to_config_param(config);
I would move it up before the u8 variable.
The code looks good otherwise. Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Thanks for fixing this!
-- With Best Regards, Andy Shevchenko
| |