Messages in this thread | | | Date | Tue, 30 Aug 2022 10:33:00 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH] phy: marvell: phy-mvebu-a3700-comphy: Remove broken reset support |
| |
On 29-08-22, 10:30, Pali Rohár wrote: > Reset support for SATA PHY is somehow broken and after calling it, kernel > is not able to detect and initialize SATA disk Samsung SSD 850 EMT0 [1]. > > Reset support was introduced in commit 934337080c6c ("phy: marvell: > phy-mvebu-a3700-comphy: Add native kernel implementation") as part of > complete rewrite of this driver. v1 patch series of that commit [2] did > not contain reset support and was tested that is working fine with > Ethernet, SATA and USB PHYs without issues too. > > So for now remove broken reset support and change implementation of > power_off callback to power off all functions on specified lane (and not > only selected function) because during startup kernel does not know which > function was selected and configured by bootloader. Same logic was used > also in v1 patch series of that commit. > > This change fixes issues with initialization of SATA disk Samsung SSD 850 > and disk is working again, like before mentioned commit. > > Once problem with PHY reset callback is solved its functionality could be > re-introduced. But for now it is unknown why it does not work.
Applied, thanks
-- ~Vinod
| |