Messages in this thread | | | Date | Tue, 30 Aug 2022 17:06:24 -0700 | Subject | Re: [PATCH 1/6] mm/gup: introduce pin_user_page() | From | John Hubbard <> |
| |
On 8/30/22 05:17, David Hildenbrand wrote: > (side note: after recent VM_BUG_ON discussions we might want to convert > the VM_BUG_ON_PAGE in sanity_check_pinned_pages())
Just realized I skipped over this point in my other response.
So, there are 28 "BUG_ON" calls in mm/gup.c, only 3 of which are BUILD_BUG_ON().
Maybe a single patch that covers all 25 at once is the way to go, I'm thinking. And of course, any patch that touches any of those lines should convert to a WARN* variant--whichever lands first.
thanks,
-- John Hubbard NVIDIA
| |