lkml.org 
[lkml]   [2022]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 54/86] net: Fix a data-race around sysctl_net_busy_poll.
    Date
    From: Kuniyuki Iwashima <kuniyu@amazon.com>

    [ Upstream commit c42b7cddea47503411bfb5f2f93a4154aaffa2d9 ]

    While reading sysctl_net_busy_poll, it can be changed concurrently.
    Thus, we need to add READ_ONCE() to its reader.

    Fixes: 060212928670 ("net: add low latency socket poll")
    Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    include/net/busy_poll.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/include/net/busy_poll.h b/include/net/busy_poll.h
    index 716b7c5f6fdd9..36e5e75e71720 100644
    --- a/include/net/busy_poll.h
    +++ b/include/net/busy_poll.h
    @@ -31,7 +31,7 @@ extern unsigned int sysctl_net_busy_poll __read_mostly;

    static inline bool net_busy_loop_on(void)
    {
    - return sysctl_net_busy_poll;
    + return READ_ONCE(sysctl_net_busy_poll);
    }

    static inline bool sk_can_busy_loop(const struct sock *sk)
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-29 13:45    [W:3.708 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site