Messages in this thread | | | Date | Mon, 29 Aug 2022 20:30:54 -0700 | Subject | Re: [PATCH 1/2] testing/selftests: Add tests for the is_signed_type() macro | From | Bart Van Assche <> |
| |
On 8/29/22 19:33, Isabella Basso wrote: >> +#include <kunit/test.h> >> +#include <linux/overflow.h> > > Nit: I don’t know if that makes a huge difference but you might include > `<linux/compiler.h>` directly to make the final object smaller. Of course, that > would ideally be a change happening in 2/2 but that was already merged :).
Right, that could have been done in patch 2/2 but I think this can also be done as a follow-up patch. I'm not sure what Kees prefers?
Thanks,
Bart.
| |