lkml.org 
[lkml]   [2022]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] cpuidle: remove redundant check in cpuidle_switch_governor
Date
gov has already been NULL checked at the beginning of
cpuidle_switch_governor, so remove redundant check.

And use pr_info instead printk to fix the following checkpatch warning.

WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then
dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...

Signed-off-by: Yu Liao <liaoyu15@huawei.com>
---
drivers/cpuidle/governor.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/cpuidle/governor.c b/drivers/cpuidle/governor.c
index 29acaf48e575..9e6865edb942 100644
--- a/drivers/cpuidle/governor.c
+++ b/drivers/cpuidle/governor.c
@@ -63,12 +63,10 @@ int cpuidle_switch_governor(struct cpuidle_governor *gov)

cpuidle_curr_governor = gov;

- if (gov) {
- list_for_each_entry(dev, &cpuidle_detected_devices, device_list)
- cpuidle_enable_device(dev);
- cpuidle_install_idle_handler();
- printk(KERN_INFO "cpuidle: using governor %s\n", gov->name);
- }
+ list_for_each_entry(dev, &cpuidle_detected_devices, device_list)
+ cpuidle_enable_device(dev);
+ cpuidle_install_idle_handler();
+ pr_info("cpuidle: using governor %s\n", gov->name);

return 0;
}
--
2.25.1
\
 
 \ /
  Last update: 2022-08-29 03:08    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog