Messages in this thread | | | Date | Sat, 27 Aug 2022 17:12:20 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 2/6] block: add dio_w_*() wrappers for pin, unpin user pages |
| |
On Sat, 27 Aug 2022 16:59:32 -0700 John Hubbard <jhubbard@nvidia.com> wrote:
> Anyway, I'll change my patch locally for now, to this: > > static inline void dio_w_unpin_user_pages(struct page **pages, > unsigned long npages) > { > /* Careful, release_pages() uses a smaller integer type for npages: */ > if (WARN_ON_ONCE(npages > (unsigned long)INT_MAX)) > return; > > release_pages(pages, (int)npages); > }
Well, it might be slower. release_pages() has a ton of fluff.
As mentioned, the above might be faster if the pages tend to have page_count()==1??
| |