lkml.org 
[lkml]   [2022]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5.10 514/545] tpm: eventlog: Fix section mismatch for DEBUG_SECTION_MISMATCH
    On Fri, Aug 19, 2022 at 05:44:44PM +0200, Greg Kroah-Hartman wrote:
    > From: Huacai Chen <chenhuacai@loongson.cn>
    >
    > commit bed4593645366ad7362a3aa7bc0d100d8d8236a8 upstream.
    >
    > If DEBUG_SECTION_MISMATCH enabled, __calc_tpm2_event_size() will not be
    > inlined, this cause section mismatch like this:
    >
    > WARNING: modpost: vmlinux.o(.text.unlikely+0xe30c): Section mismatch in reference from the variable L0 to the function .init.text:early_ioremap()
    > The function L0() references
    > the function __init early_memremap().
    > This is often because L0 lacks a __init
    > annotation or the annotation of early_ioremap is wrong.
    >
    > Fix it by using __always_inline instead of inline for the called-once
    > function __calc_tpm2_event_size().
    >
    > Fixes: 44038bc514a2 ("tpm: Abstract crypto agile event size calculations")
    > Cc: stable@vger.kernel.org # v5.3
    > Reported-by: WANG Xuerui <git@xen0n.name>
    > Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
    > Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
    > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > ---
    > include/linux/tpm_eventlog.h | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > --- a/include/linux/tpm_eventlog.h
    > +++ b/include/linux/tpm_eventlog.h
    > @@ -157,7 +157,7 @@ struct tcg_algorithm_info {
    > * Return: size of the event on success, 0 on failure
    > */
    >
    > -static inline int __calc_tpm2_event_size(struct tcg_pcr_event2_head *event,
    > +static __always_inline int __calc_tpm2_event_size(struct tcg_pcr_event2_head *event,
    > struct tcg_pcr_event *event_header,
    > bool do_mapping)
    > {
    >
    >

    Thank you. I'll pick this.

    Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

    BR, Jarkko

    \
     
     \ /
      Last update: 2022-08-26 08:19    [W:4.147 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site