lkml.org 
[lkml]   [2022]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] cxl: Replace HDM decoder granularity magic numbers
Date
On Mon, Aug 22, 2022 at 10:34:46AM -0700, Dan Williams wrote:
> Adam Manzanares wrote:
> > When reviewing the CFMWS parsing code that deals with the HDM decoders,
> > I noticed a couple of magic numbers. This commit replaces these magic numbers
> > with constants defined by the CXL 2.0 specification.
>
> I have a small quibble with CXL_DECODER_MAX_GRANULARITY_ORDER. How about
> CXL_DECODER_MAX_ENCODED_IG? Because the value is not the 'power of 2
> order' it's the 'power of 2 order - 8'.

Sounds reasonable to me. I will also make this change in v2.
\
 
 \ /
  Last update: 2022-08-25 07:37    [W:1.300 / U:1.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site