Messages in this thread | | | Subject | Re: [PATCH net-next 0/2] net: ethtool add VxLAN to the NFC API | From | "huangguangbin (A)" <> | Date | Mon, 22 Aug 2022 22:46:14 +0800 |
| |
On 2022/8/18 2:16, Jakub Kicinski wrote: > On Wed, 17 Aug 2022 22:35:36 +0800 Guangbin Huang wrote: >> This series adds support for steering VxLAN flows using the ethtool NFC >> interface, and implements it for hns3 devices. > > Why can't TC be used for this? Let's not duplicate the same > functionality in two places, TC flower can already match on > tunnel headers. > . > Hi Jakub, 1. I check the manual and implement of TC flower, it doesn't seems to support configuring flows steering to a specific queue. 2. Our hns3 driver has supported configuring some type of flows steering to a specific queue by ethtool -U command, many users have already use ethtool way. 3. In addition, if our driver supports TC flower to configure flows steering to a specific queue, can we allow user to simultaneously use TC flower and ethtool to configure flow rules? Could the rules configured by TC flower be queried by ethtool -u? If two ways can be existing, I think it is more complicated for driver to manage flow rules.
| |