Messages in this thread | | | Date | Tue, 2 Aug 2022 14:19:02 +0300 | From | Vladimir Oltean <> | Subject | Re: [PATCH net-next v1 02/10] net: dsa: microchip: allow to pass return values for PHY read/write accesses |
| |
On Fri, Jul 29, 2022 at 03:03:38PM +0200, Oleksij Rempel wrote: > PHY access may end with errors on different levels. So, allow to forward > return values where possible. > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > -void ksz8_w_phy(struct ksz_device *dev, u16 phy, u16 reg, u16 val) > +int ksz8_w_phy(struct ksz_device *dev, u16 phy, u16 reg, u16 val) > { > u8 restart, speed, ctrl, data; > const u16 *regs; > @@ -787,6 +789,9 @@ void ksz8_w_phy(struct ksz_device *dev, u16 phy, u16 reg, u16 val) > default: > break; > } > + > +
Too many empty lines.
> + return 0; > }
| |