lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 530/545] KVM: x86: Avoid theoretical NULL pointer dereference in kvm_irq_delivery_to_apic_fast()
    Date
    From: Vitaly Kuznetsov <vkuznets@redhat.com>

    commit 00b5f37189d24ac3ed46cb7f11742094778c46ce upstream

    When kvm_irq_delivery_to_apic_fast() is called with APIC_DEST_SELF
    shorthand, 'src' must not be NULL. Crash the VM with KVM_BUG_ON()
    instead of crashing the host.

    Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
    Message-Id: <20220325132140.25650-3-vkuznets@redhat.com>
    Cc: stable@vger.kernel.org
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
    Signed-off-by: Stefan Ghinea <stefan.ghinea@windriver.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    arch/x86/kvm/lapic.c | 4 ++++
    1 file changed, 4 insertions(+)

    --- a/arch/x86/kvm/lapic.c
    +++ b/arch/x86/kvm/lapic.c
    @@ -991,6 +991,10 @@ bool kvm_irq_delivery_to_apic_fast(struc
    *r = -1;

    if (irq->shorthand == APIC_DEST_SELF) {
    + if (KVM_BUG_ON(!src, kvm)) {
    + *r = 0;
    + return true;
    + }
    *r = kvm_apic_set_irq(src->vcpu, irq, dest_map);
    return true;
    }

    \
     
     \ /
      Last update: 2022-08-19 18:52    [W:5.659 / U:0.352 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site