lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 409/545] ASoC: qcom: q6dsp: Fix an off-by-one in q6adm_alloc_copp()
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    [ Upstream commit 673f58f62ca6fc98979d1cf3fe89c3ff33f29b2e ]

    find_first_zero_bit() returns MAX_COPPS_PER_PORT at max here.
    So 'idx' should be tested with ">=" or the test can't match.

    Fixes: 7b20b2be51e1 ("ASoC: qdsp6: q6adm: Add q6adm driver")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Link: https://lore.kernel.org/r/0fca3271649736053eb9649d87e1ca01b056be40.1658394124.git.christophe.jaillet@wanadoo.fr
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/qcom/qdsp6/q6adm.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/sound/soc/qcom/qdsp6/q6adm.c b/sound/soc/qcom/qdsp6/q6adm.c
    index 72f29720398c..182d36a34faf 100644
    --- a/sound/soc/qcom/qdsp6/q6adm.c
    +++ b/sound/soc/qcom/qdsp6/q6adm.c
    @@ -217,7 +217,7 @@ static struct q6copp *q6adm_alloc_copp(struct q6adm *adm, int port_idx)
    idx = find_first_zero_bit(&adm->copp_bitmap[port_idx],
    MAX_COPPS_PER_PORT);

    - if (idx > MAX_COPPS_PER_PORT)
    + if (idx >= MAX_COPPS_PER_PORT)
    return ERR_PTR(-EBUSY);

    c = kzalloc(sizeof(*c), GFP_ATOMIC);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-19 18:43    [W:4.035 / U:0.588 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site