lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 398/545] rpmsg: qcom_smd: Fix refcount leak in qcom_smd_parse_edge
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit 65382585f067d4256ba087934f30f85c9b6984de ]

    of_parse_phandle() returns a node pointer with refcount
    incremented, we should use of_node_put() on it when done.

    Fixes: 53e2822e56c7 ("rpmsg: Introduce Qualcomm SMD backend")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    Link: https://lore.kernel.org/r/20220511120737.57374-1-linmq006@gmail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/rpmsg/qcom_smd.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c
    index a4db9f6100d2..0b1e853d8c91 100644
    --- a/drivers/rpmsg/qcom_smd.c
    +++ b/drivers/rpmsg/qcom_smd.c
    @@ -1364,6 +1364,7 @@ static int qcom_smd_parse_edge(struct device *dev,
    }

    edge->ipc_regmap = syscon_node_to_regmap(syscon_np);
    + of_node_put(syscon_np);
    if (IS_ERR(edge->ipc_regmap)) {
    ret = PTR_ERR(edge->ipc_regmap);
    goto put_node;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-19 18:35    [W:2.722 / U:0.260 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site