lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 339/545] RDMA/hfi1: fix potential memory leak in setup_base_ctxt()
    Date
    From: Jianglei Nie <niejianglei2021@163.com>

    [ Upstream commit aa2a1df3a2c85f855af7d54466ac10bd48645d63 ]

    setup_base_ctxt() allocates a memory chunk for uctxt->groups with
    hfi1_alloc_ctxt_rcv_groups(). When init_user_ctxt() fails, uctxt->groups
    is not released, which will lead to a memory leak.

    We should release the uctxt->groups with hfi1_free_ctxt_rcv_groups()
    when init_user_ctxt() fails.

    Fixes: e87473bc1b6c ("IB/hfi1: Only set fd pointer when base context is completely initialized")
    Link: https://lore.kernel.org/r/20220711070718.2318320-1-niejianglei2021@163.com
    Signed-off-by: Jianglei Nie <niejianglei2021@163.com>
    Acked-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
    Signed-off-by: Leon Romanovsky <leon@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/infiniband/hw/hfi1/file_ops.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/infiniband/hw/hfi1/file_ops.c b/drivers/infiniband/hw/hfi1/file_ops.c
    index cfc2110fc38a..d84b1098762c 100644
    --- a/drivers/infiniband/hw/hfi1/file_ops.c
    +++ b/drivers/infiniband/hw/hfi1/file_ops.c
    @@ -1220,8 +1220,10 @@ static int setup_base_ctxt(struct hfi1_filedata *fd,
    goto done;

    ret = init_user_ctxt(fd, uctxt);
    - if (ret)
    + if (ret) {
    + hfi1_free_ctxt_rcv_groups(uctxt);
    goto done;
    + }

    user_init(uctxt);

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-19 18:27    [W:5.359 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site