lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 270/545] mtd: maps: Fix refcount leak in of_flash_probe_versatile
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit 33ec82a6d2b119938f26e5c8040ed5d92378eb54 ]

    of_find_matching_node_and_match() returns a node pointer with refcount
    incremented, we should use of_node_put() on it when not need anymore.
    Add missing of_node_put() to avoid refcount leak.

    Fixes: b0afd44bc192 ("mtd: physmap_of: add a hook for Versatile write protection")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
    Link: https://lore.kernel.org/linux-mtd/20220523140205.48625-1-linmq006@gmail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mtd/maps/physmap-versatile.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/mtd/maps/physmap-versatile.c b/drivers/mtd/maps/physmap-versatile.c
    index ad7cd9cfaee0..297a50957356 100644
    --- a/drivers/mtd/maps/physmap-versatile.c
    +++ b/drivers/mtd/maps/physmap-versatile.c
    @@ -207,6 +207,7 @@ int of_flash_probe_versatile(struct platform_device *pdev,

    versatile_flashprot = (enum versatile_flashprot)devid->data;
    rmap = syscon_node_to_regmap(sysnp);
    + of_node_put(sysnp);
    if (IS_ERR(rmap))
    return PTR_ERR(rmap);

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-19 18:24    [W:2.452 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site