lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 152/545] pwm: sifive: Dont check the return code of pwmchip_remove()
    Date
    From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

    [ Upstream commit ceb2c2842f3664dcc4e6d8cb317e1e83bb81b1e5 ]

    pwmchip_remove() returns always 0. Don't use the value to make it
    possible to eventually change the function to return void. Also the
    driver core ignores the return value of pwm_sifive_remove().

    Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pwm/pwm-sifive.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c
    index 2485fbaaead2..8c6de4f41076 100644
    --- a/drivers/pwm/pwm-sifive.c
    +++ b/drivers/pwm/pwm-sifive.c
    @@ -296,7 +296,7 @@ static int pwm_sifive_remove(struct platform_device *dev)
    struct pwm_sifive_ddata *ddata = platform_get_drvdata(dev);
    bool is_enabled = false;
    struct pwm_device *pwm;
    - int ret, ch;
    + int ch;

    for (ch = 0; ch < ddata->chip.npwm; ch++) {
    pwm = &ddata->chip.pwms[ch];
    @@ -309,10 +309,10 @@ static int pwm_sifive_remove(struct platform_device *dev)
    clk_disable(ddata->clk);

    clk_disable_unprepare(ddata->clk);
    - ret = pwmchip_remove(&ddata->chip);
    + pwmchip_remove(&ddata->chip);
    clk_notifier_unregister(ddata->clk, &ddata->notifier);

    - return ret;
    + return 0;
    }

    static const struct of_device_id pwm_sifive_of_match[] = {
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-19 18:08    [W:4.045 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site