Messages in this thread | | | From | Andy Shevchenko <> | Date | Thu, 18 Aug 2022 22:10:58 +0300 | Subject | Re: [PATCH linux-phy v2 1/4] string.h: Add str_has_proper_prefix() |
| |
On Wed, Aug 17, 2022 at 11:06 PM Marek Behún <kabel@kernel.org> wrote: > > Add str_has_proper_prefix(), similar to str_has_prefix(), but requires > that the prefix is proper: the string itself must be longer than the > prefix. > > Signed-off-by: Marek Behún <kabel@kernel.org> > --- > Andy, Kees, could you ack this if it is ok?
Seems to me there are too many strlen():s. One is hidden in strncmp().
Besides not the good naming (what 'proper' means), the entire function is not needed. You may simply call
str_has_prefix() && p[len] != '\0';
Correct?
-- With Best Regards, Andy Shevchenko
| |