lkml.org 
[lkml]   [2022]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3] platform/chrome: cros_ec: Send host event for prepare/complete
    On Tue, Aug 02, 2022 at 11:40:08AM -0600, Tim Van Patten wrote:
    > Update cros_ec_lpc_pm_ops to call cros_ec_lpc_prepare() during PM
    > .prepare() and cros_ec_lpc_complete() during .complete(). This allows the
    > EC to log entry/exit of AP's suspend/resume more accurately.

    As what I commented on [1], the term "host event" in the commit title is
    confusing. Also, as this is a cros_ec_lpc specific patch, please change
    the prefix.

    [1]: https://patchwork.kernel.org/project/chrome-platform/patch/20220706205136.v2.1.Ic7a7c81f880ab31533652e0928aa6e687bb268b5@changeid/#24934911

    > -static int cros_ec_lpc_resume(struct device *dev)
    > +static void cros_ec_lpc_complete(struct device *dev)
    > {
    > struct cros_ec_device *ec_dev = dev_get_drvdata(dev);
    > + int ret;
    > +
    > + ret = cros_ec_resume(ec_dev);
    >
    > - return cros_ec_resume(ec_dev);
    > + dev_info(dev, "EC resume completed: ret = %d\n", ret);

    cros_ec_resume() always returns 0.

    \
     
     \ /
      Last update: 2022-08-18 06:09    [W:8.981 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site