Messages in this thread | | | Subject | Re: [PATCH v2 01/16] hwmon: (mr75203) fix VM sensor allocation when "intel, vm-map" not defined | Date | Thu, 18 Aug 2022 23:01:53 +0300 | From | "Farber, Eliav" <> |
| |
On 8/18/2022 10:40 PM, Guenter Roeck wrote: > "intel,vm-map" is listed as required property in moortec,mr75203.yaml. > If it is missing, the probe function should fail.
Indeed according to moortec,mr75203.yaml "intel,vm-map" is listed as required but the code indicates otherwise:
/* * Incase intel,vm-map property is not defined, we assume * incremental channel numbers. */
The probe function takes care in case it is missing and does not fail. It also seems less reasonable that an Intel proprietary parameter will be required and not optional. So in patch 03 I fixed the moortec,mr75203.yaml documentation and changed it to be optional.
-- Regards, Eliav
| |