lkml.org 
[lkml]   [2022]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] binderfs: rework superblock destruction
On Wed, Aug 17, 2022 at 02:59:02PM +0100, Al Viro wrote:
> On Wed, Aug 17, 2022 at 03:03:06PM +0200, Christian Brauner wrote:
>
> > +static void binderfs_kill_super(struct super_block *sb)
> > +{
> > + struct binderfs_info *info = sb->s_fs_info;
> > +
> > + if (info && info->ipc_ns)
> > + put_ipc_ns(info->ipc_ns);
> > +
> > + kfree(info);
> > + kill_litter_super(sb);
> > +}
>
> Other way round, please - shut the superblock down, *then*
> free the objects it'd been using. IOW,

I wondered about that but a lot of places do it the other way around.
So maybe the expected order should be documented somewhere.

\
 
 \ /
  Last update: 2022-08-17 16:03    [W:0.048 / U:2.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site