Messages in this thread | | | Date | Wed, 17 Aug 2022 03:18:04 +0100 | From | Al Viro <> | Subject | Re: [PATCH] improve the kernel quality and reduce the amount of BS patches |
| |
On Wed, Aug 17, 2022 at 03:09:02AM +0100, Al Viro wrote: > this idiocy has gone too far > > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Seriously, folks - the stream of patches with no better explanations than "The Most Holy checkpatch.pl Says So, Must Appease The Spirits" ought to stop.
If you are changing something, take care to explain _why_ is the change made. Reference to a tool that has pointed you towards the location you are changing does not replace that. checkpatch.pl is a script. A dumb one. It's a bunch of heuristics that correlate with code being potentially fishy and worth looking into; those are occasionally useful, but it's not an oracle.
| |