lkml.org 
[lkml]   [2022]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 0809/1157] usb: aspeed-vhub: Fix refcount leak bug in ast_vhub_init_desc()
    Date
    From: Liang He <windhl@126.com>

    [ Upstream commit 220fafb4ed04187e9c17be4152da5a7f2ffbdd8c ]

    We should call of_node_put() for the reference returned by
    of_get_child_by_name() which has increased the refcount.

    Fixes: 30d2617fd7ed ("usb: gadget: aspeed: allow to set usb strings in device tree")
    Signed-off-by: Liang He <windhl@126.com>
    Link: https://lore.kernel.org/r/20220713120528.368168-1-windhl@126.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/gadget/udc/aspeed-vhub/hub.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/usb/gadget/udc/aspeed-vhub/hub.c b/drivers/usb/gadget/udc/aspeed-vhub/hub.c
    index 65cd4e46f031..e2207d014620 100644
    --- a/drivers/usb/gadget/udc/aspeed-vhub/hub.c
    +++ b/drivers/usb/gadget/udc/aspeed-vhub/hub.c
    @@ -1059,8 +1059,10 @@ static int ast_vhub_init_desc(struct ast_vhub *vhub)
    /* Initialize vhub String Descriptors. */
    INIT_LIST_HEAD(&vhub->vhub_str_desc);
    desc_np = of_get_child_by_name(vhub_np, "vhub-strings");
    - if (desc_np)
    + if (desc_np) {
    ret = ast_vhub_of_parse_str_desc(vhub, desc_np);
    + of_node_put(desc_np);
    + }
    else
    ret = ast_vhub_str_alloc_add(vhub, &ast_vhub_strings);

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-16 06:44    [W:3.540 / U:5.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site