lkml.org 
[lkml]   [2022]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 0781/1157] PCI: endpoint: Dont stop controller when unbinding endpoint function
    Date
    From: Shunsuke Mie <mie@igel.co.jp>

    [ Upstream commit 1bc2b7bfba6e2f64edf5e246f3af2967261f6c3d ]

    Unbinding an endpoint function from the endpoint controller shouldn't stop
    the controller. This is especially a problem for multi-function endpoints
    where other endpoints may still be active.

    Don't stop the controller when unbinding one of its endpoints. Normally
    the controller is stopped via configfs.

    Fixes: 349e7a85b25f ("PCI: endpoint: functions: Add an EP function to test PCI")
    Link: https://lore.kernel.org/r/20220622040924.113279-1-mie@igel.co.jp
    Signed-off-by: Shunsuke Mie <mie@igel.co.jp>
    Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
    Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pci/endpoint/functions/pci-epf-test.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
    index 5b833f00e980..a5ed779b0a51 100644
    --- a/drivers/pci/endpoint/functions/pci-epf-test.c
    +++ b/drivers/pci/endpoint/functions/pci-epf-test.c
    @@ -627,7 +627,6 @@ static void pci_epf_test_unbind(struct pci_epf *epf)

    cancel_delayed_work(&epf_test->cmd_handler);
    pci_epf_test_clean_dma_chan(epf_test);
    - pci_epc_stop(epc);
    for (bar = 0; bar < PCI_STD_NUM_BARS; bar++) {
    epf_bar = &epf->bar[bar];

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-16 06:43    [W:2.468 / U:0.348 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site