lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 054/779] dt-bindings: riscv: fix SiFive l2-caches cache-sets
    Date
    From: Conor Dooley <conor.dooley@microchip.com>

    commit b60cf8e59e61133b6c9514ff8d8c8d7049d040ef upstream.

    Fix device tree schema validation error messages for the SiFive
    Unmatched: ' cache-sets:0:0: 1024 was expected'.

    The existing bindings allow for just 1024 cache-sets but the fu740 on
    Unmatched the has 2048 cache-sets. The ISA itself permits any arbitrary
    power of two, however this is not supported by dt-schema. The RTL for
    the IP, to which the number of cache-sets is a tunable parameter, has
    been released publicly so speculatively adding a small number of
    "reasonable" values seems unwise also.

    Instead, as the binding only supports two distinct controllers: add 2048
    and explicitly lock it to the fu740's l2 cache while limiting 1024 to
    the l2 cache on the fu540.

    Fixes: af951c3a113b ("dt-bindings: riscv: Update l2 cache DT documentation to add support for SiFive FU740")
    Reported-by: Atul Khare <atulkhare@rivosinc.com>
    Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
    Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
    Cc: stable@vger.kernel.org
    Link: https://lore.kernel.org/r/20220803185359.942928-1-mail@conchuod.ie
    Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    Documentation/devicetree/bindings/riscv/sifive-l2-cache.yaml | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    --- a/Documentation/devicetree/bindings/riscv/sifive-l2-cache.yaml
    +++ b/Documentation/devicetree/bindings/riscv/sifive-l2-cache.yaml
    @@ -47,7 +47,7 @@ properties:
    const: 2

    cache-sets:
    - const: 1024
    + enum: [1024, 2048]

    cache-size:
    const: 2097152
    @@ -85,6 +85,8 @@ then:
    description: |
    Must contain entries for DirError, DataError and DataFail signals.
    maxItems: 3
    + cache-sets:
    + const: 1024

    else:
    properties:
    @@ -92,6 +94,8 @@ else:
    description: |
    Must contain entries for DirError, DataError, DataFail, DirFail signals.
    minItems: 4
    + cache-sets:
    + const: 2048

    additionalProperties: false


    \
     
     \ /
      Last update: 2022-08-15 20:22    [W:2.228 / U:0.332 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site