lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 051/779] parisc: Check the return value of ioremap() in lba_driver_probe()
    Date
    From: William Dean <williamsukatube@gmail.com>

    commit cf59f34d7f978d14d6520fd80a78a5ad5cb8abf8 upstream.

    The function ioremap() in lba_driver_probe() can fail, so
    its return value should be checked.

    Fixes: 4bdc0d676a643 ("remove ioremap_nocache and devm_ioremap_nocache")
    Reported-by: Hacash Robot <hacashRobot@santino.com>
    Signed-off-by: William Dean <williamsukatube@gmail.com>
    Signed-off-by: Helge Deller <deller@gmx.de>
    Cc: <stable@vger.kernel.org> # v5.6+
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/parisc/lba_pci.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    --- a/drivers/parisc/lba_pci.c
    +++ b/drivers/parisc/lba_pci.c
    @@ -1476,9 +1476,13 @@ lba_driver_probe(struct parisc_device *d
    u32 func_class;
    void *tmp_obj;
    char *version;
    - void __iomem *addr = ioremap(dev->hpa.start, 4096);
    + void __iomem *addr;
    int max;

    + addr = ioremap(dev->hpa.start, 4096);
    + if (addr == NULL)
    + return -ENOMEM;
    +
    /* Read HW Rev First */
    func_class = READ_REG32(addr + LBA_FCLASS);


    \
     
     \ /
      Last update: 2022-08-15 20:19    [W:4.016 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site