lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 0854/1157] staging: fbtft: core: set smem_len before fb_deferred_io_init call
    Date
    From: Peter Suti <peter.suti@streamunlimited.com>

    [ Upstream commit 81e878887ff82a7dd42f22951391069a5d520627 ]

    The fbtft_framebuffer_alloc() calls fb_deferred_io_init() before
    initializing info->fix.smem_len. It is set to zero by the
    framebuffer_alloc() function. It will trigger a WARN_ON() at the
    start of fb_deferred_io_init() and the function will not do anything.

    Fixes: 856082f021a2 ("fbdev: defio: fix the pagelist corruption")
    Signed-off-by: Peter Suti <peter.suti@streamunlimited.com>
    Link: https://lore.kernel.org/r/20220727073550.1491126-1-peter.suti@streamunlimited.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/staging/fbtft/fbtft-core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
    index 60b2278d8b16..ebf4e8ce4de9 100644
    --- a/drivers/staging/fbtft/fbtft-core.c
    +++ b/drivers/staging/fbtft/fbtft-core.c
    @@ -655,7 +655,6 @@ struct fb_info *fbtft_framebuffer_alloc(struct fbtft_display *display,
    fbdefio->delay = HZ / fps;
    fbdefio->sort_pagereflist = true;
    fbdefio->deferred_io = fbtft_deferred_io;
    - fb_deferred_io_init(info);

    snprintf(info->fix.id, sizeof(info->fix.id), "%s", dev->driver->name);
    info->fix.type = FB_TYPE_PACKED_PIXELS;
    @@ -666,6 +665,7 @@ struct fb_info *fbtft_framebuffer_alloc(struct fbtft_display *display,
    info->fix.line_length = width * bpp / 8;
    info->fix.accel = FB_ACCEL_NONE;
    info->fix.smem_len = vmem_size;
    + fb_deferred_io_init(info);

    info->var.rotate = pdata->rotate;
    info->var.xres = width;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-09-17 16:26    [W:3.082 / U:0.200 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site