lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH bpf-next 2/3] bpf: Add support for writing to nf_conn:mark
    Toke Høiland-Jørgensen <toke@kernel.org> wrote:
    > > Support direct writes to nf_conn:mark from TC and XDP prog types. This
    > > is useful when applications want to store per-connection metadata. This
    > > is also particularly useful for applications that run both bpf and
    > > iptables/nftables because the latter can trivially access this metadata.
    > >
    > > One example use case would be if a bpf prog is responsible for advanced
    > > packet classification and iptables/nftables is later used for routing
    > > due to pre-existing/legacy code.
    > >
    > > Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>
    >
    > Didn't we agree the last time around that all field access should be
    > using helper kfuncs instead of allowing direct writes to struct nf_conn?

    I don't see why ct->mark needs special handling.

    It might be possible we need to change accesses on nf/tc side to use
    READ/WRITE_ONCE though.

    \
     
     \ /
      Last update: 2022-08-16 04:27    [W:4.398 / U:0.368 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site