lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 0963/1157] leds: pwm-multicolor: Dont show -EPROBE_DEFER as errors
    Date
    From: Emil Renner Berthing <emil.renner.berthing@canonical.com>

    [ Upstream commit 399e7aa82105ea46d8998fa535b047541c48030f ]

    When requesting a PWM it might return -EPROBE_DEFER if it hasn't probed
    yet. This is not an error, so just propagate the -EPROBE_DEFER without
    logging anything. There is already dev_err_probe for exactly this
    situation.

    Fixes: 9fa2762110dd ("leds: Add PWM multicolor driver")
    Signed-off-by: Emil Renner Berthing <emil.renner.berthing@canonical.com>
    Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
    Signed-off-by: Pavel Machek <pavel@ucw.cz>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/leds/rgb/leds-pwm-multicolor.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/leds/rgb/leds-pwm-multicolor.c b/drivers/leds/rgb/leds-pwm-multicolor.c
    index 45e38708ecb1..eb67b89d28e9 100644
    --- a/drivers/leds/rgb/leds-pwm-multicolor.c
    +++ b/drivers/leds/rgb/leds-pwm-multicolor.c
    @@ -72,8 +72,7 @@ static int iterate_subleds(struct device *dev, struct pwm_mc_led *priv,
    pwmled = &priv->leds[priv->mc_cdev.num_colors];
    pwmled->pwm = devm_fwnode_pwm_get(dev, fwnode, NULL);
    if (IS_ERR(pwmled->pwm)) {
    - ret = PTR_ERR(pwmled->pwm);
    - dev_err(dev, "unable to request PWM: %d\n", ret);
    + ret = dev_err_probe(dev, PTR_ERR(pwmled->pwm), "unable to request PWM\n");
    goto release_fwnode;
    }
    pwm_init_state(pwmled->pwm, &pwmled->state);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-16 02:54    [W:4.291 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site