lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 0960/1157] net: 9p: fix refcount leak in p9_read_work() error handling
    Date
    From: Hangyu Hua <hbh25y@gmail.com>

    [ Upstream commit 4ac7573e1f9333073fa8d303acc941c9b7ab7f61 ]

    p9_req_put need to be called when m->rreq->rc.sdata is NULL to avoid
    temporary refcount leak.

    Link: https://lkml.kernel.org/r/20220712104438.30800-1-hbh25y@gmail.com
    Fixes: 728356dedeff ("9p: Add refcount to p9_req_t")
    Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
    [Dominique: commit wording adjustments, p9_req_put argument fixes for rebase]
    Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/9p/trans_fd.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/net/9p/trans_fd.c b/net/9p/trans_fd.c
    index 007c3f45fe05..e758978b44be 100644
    --- a/net/9p/trans_fd.c
    +++ b/net/9p/trans_fd.c
    @@ -343,6 +343,7 @@ static void p9_read_work(struct work_struct *work)
    p9_debug(P9_DEBUG_ERROR,
    "No recv fcall for tag %d (req %p), disconnecting!\n",
    m->rc.tag, m->rreq);
    + p9_req_put(m->client, m->rreq);
    m->rreq = NULL;
    err = -EIO;
    goto error;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-16 02:51    [W:2.614 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site