lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 0914/1157] rpmsg: Fix possible refcount leak in rpmsg_register_device_override()
    Date
    From: Hangyu Hua <hbh25y@gmail.com>

    [ Upstream commit d7bd416d35121c95fe47330e09a5c04adbc5f928 ]

    rpmsg_register_device_override need to call put_device to free vch when
    driver_set_override fails.

    Fix this by adding a put_device() to the error path.

    Fixes: bb17d110cbf2 ("rpmsg: Fix calling device_lock() on non-initialized device")
    Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
    Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
    Link: https://lore.kernel.org/r/20220624024120.11576-1-hbh25y@gmail.com
    Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/rpmsg/rpmsg_core.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c
    index 290c1f02da10..5a47cad89fdc 100644
    --- a/drivers/rpmsg/rpmsg_core.c
    +++ b/drivers/rpmsg/rpmsg_core.c
    @@ -618,6 +618,7 @@ int rpmsg_register_device_override(struct rpmsg_device *rpdev,
    strlen(driver_override));
    if (ret) {
    dev_err(dev, "device_set_override failed: %d\n", ret);
    + put_device(dev);
    return ret;
    }
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-16 02:42    [W:3.641 / U:1.792 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site