lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 0909/1157] remoteproc: k3-r5: Fix refcount leak in k3_r5_cluster_of_init
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit fa220c05d282e7479abe08b54e3bdffd06c25e97 ]

    Every iteration of for_each_available_child_of_node() decrements
    the reference count of the previous node.
    When breaking early from a for_each_available_child_of_node() loop,
    we need to explicitly call of_node_put() on the child node.
    Add missing of_node_put() to avoid refcount leak.

    Fixes: 6dedbd1d5443 ("remoteproc: k3-r5: Add a remoteproc driver for R5F subsystem")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Acked-by: Suman Anna <s-anna@ti.com>
    Link: https://lore.kernel.org/r/20220605083334.23942-1-linmq006@gmail.com
    Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/remoteproc/ti_k3_r5_remoteproc.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/remoteproc/ti_k3_r5_remoteproc.c b/drivers/remoteproc/ti_k3_r5_remoteproc.c
    index 4840ad906018..0481926c6975 100644
    --- a/drivers/remoteproc/ti_k3_r5_remoteproc.c
    +++ b/drivers/remoteproc/ti_k3_r5_remoteproc.c
    @@ -1655,6 +1655,7 @@ static int k3_r5_cluster_of_init(struct platform_device *pdev)
    if (!cpdev) {
    ret = -ENODEV;
    dev_err(dev, "could not get R5 core platform device\n");
    + of_node_put(child);
    goto fail;
    }

    @@ -1663,6 +1664,7 @@ static int k3_r5_cluster_of_init(struct platform_device *pdev)
    dev_err(dev, "k3_r5_core_of_init failed, ret = %d\n",
    ret);
    put_device(&cpdev->dev);
    + of_node_put(child);
    goto fail;
    }

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-16 02:41    [W:2.778 / U:1.652 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site