lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 0800/1157] of: device: Fix missing of_node_put() in of_dma_set_restricted_buffer
    Date
    From: Liang He <windhl@126.com>

    [ Upstream commit d17e37c41b7ed38459957a5d2968ba61516fd5c2 ]

    We should use of_node_put() for the reference 'node' returned by
    of_parse_phandle() which will increase the refcount.

    Fixes: fec9b625095f ("of: Add plumbing for restricted DMA pool")
    Co-authored-by: Miaoqian Lin <linmq006@gmail.com>
    Signed-off-by: Liang He <windhl@126.com>
    Signed-off-by: Rob Herring <robh@kernel.org>
    Link: https://lore.kernel.org/r/20220702014449.263772-1-windhl@126.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/of/device.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/drivers/of/device.c b/drivers/of/device.c
    index 874f031442dc..75b6cbffa755 100644
    --- a/drivers/of/device.c
    +++ b/drivers/of/device.c
    @@ -81,8 +81,11 @@ of_dma_set_restricted_buffer(struct device *dev, struct device_node *np)
    * restricted-dma-pool region is allowed.
    */
    if (of_device_is_compatible(node, "restricted-dma-pool") &&
    - of_device_is_available(node))
    + of_device_is_available(node)) {
    + of_node_put(node);
    break;
    + }
    + of_node_put(node);
    }

    /*
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-16 02:30    [W:5.158 / U:0.524 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site