lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 0546/1157] drm/amd/display: fix signedness bug in execute_synaptics_rc_command()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 06ac561fb0edf868f7b292fb4a3c8ffbbb1e14bb ]

    The "ret" variable needs to be signed for the error handling to work.

    Fixes: 2ca97adccdc9 ("drm/amd/display: Add Synaptics Fifo Reset Workaround")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
    index 7c799ddc1d27..82c04af09d18 100644
    --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
    +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
    @@ -571,7 +571,7 @@ static bool execute_synaptics_rc_command(struct drm_dp_aux *aux,
    unsigned char rc_cmd = 0;
    unsigned char rc_result = 0xFF;
    unsigned char i = 0;
    - uint8_t ret = 0;
    + int ret;

    if (is_write_cmd) {
    // write rc data
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-16 02:09    [W:3.434 / U:0.428 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site