lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 0567/1157] net: ice: fix error NETIF_F_HW_VLAN_CTAG_FILTER check in ice_vsi_sync_fltr()
    Date
    From: Jian Shen <shenjian15@huawei.com>

    [ Upstream commit 7dc839fe47611e6995f370cae37b9797cf7d2672 ]

    vsi->current_netdev_flags is used store the current net device
    flags, not the active netdevice features. So it should use
    vsi->netdev->featurs, rather than vsi->current_netdev_flags
    to check NETIF_F_HW_VLAN_CTAG_FILTER.

    Fixes: 1babaf77f49d ("ice: Advertise 802.1ad VLAN filtering and offloads for PF netdev")
    Signed-off-by: Jian Shen <shenjian15@huawei.com>
    Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
    Acked-by: Tony Nguyen <anthony.l.nguyen@intel.com>
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/intel/ice/ice_main.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
    index 9f02b60459f1..bc68dc5c6927 100644
    --- a/drivers/net/ethernet/intel/ice/ice_main.c
    +++ b/drivers/net/ethernet/intel/ice/ice_main.c
    @@ -433,7 +433,7 @@ static int ice_vsi_sync_fltr(struct ice_vsi *vsi)
    IFF_PROMISC;
    goto out_promisc;
    }
    - if (vsi->current_netdev_flags &
    + if (vsi->netdev->features &
    NETIF_F_HW_VLAN_CTAG_FILTER)
    vlan_ops->ena_rx_filtering(vsi);
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-16 02:09    [W:2.678 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site