lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 0458/1157] media: mediatek: vcodec: decoder: Fix 4K frame size enumeration
    Date
    From: Chen-Yu Tsai <wenst@chromium.org>

    [ Upstream commit f1748f8f8174a65a885a8e6c0dc11658a6705ac2 ]

    This partially reverts commit b018be06f3c7 ("media: mediatek: vcodec:
    Read max resolution from dec_capability"). In this commit, the maximum
    resolution ended up being a function of both the firmware capability and
    the current set format.

    However, frame size enumeration for output (coded) formats should not
    depend on the format set, but should return supported resolutions for
    the format requested by userspace.

    Fix this so that the driver returns the supported resolutions correctly,
    even if the instance only has default settings, or if the output format
    is currently set to VP8F, which does not support 4K.

    This adds an copy of special casing for !VP8 and 4K support. The other
    existing copy will be removed when .max_{width,height} are removed from
    |struct mtk_vcodec_ctx| in a subsequent patch.

    Fixes: b018be06f3c7 ("media: mediatek: vcodec: Read max resolution from dec_capability")
    Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
    Tested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c | 2 --
    .../platform/mediatek/vcodec/mtk_vcodec_dec_stateless.c | 7 +++++++
    2 files changed, 7 insertions(+), 2 deletions(-)

    diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c
    index 01836a1c7d3f..393b127138f3 100644
    --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c
    +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c
    @@ -536,8 +536,6 @@ static int vidioc_enum_framesizes(struct file *file, void *priv,
    fsize->type = V4L2_FRMSIZE_TYPE_STEPWISE;
    fsize->stepwise = dec_pdata->vdec_framesizes[i].stepwise;

    - fsize->stepwise.max_width = ctx->max_width;
    - fsize->stepwise.max_height = ctx->max_height;
    mtk_v4l2_debug(1, "%x, %d %d %d %d %d %d",
    ctx->dev->dec_capability,
    fsize->stepwise.min_width,
    diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_stateless.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_stateless.c
    index 16d55785d84b..9a4d3e3658aa 100644
    --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_stateless.c
    +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_stateless.c
    @@ -360,6 +360,13 @@ static void mtk_vcodec_add_formats(unsigned int fourcc,

    mtk_vdec_framesizes[count_framesizes].fourcc = fourcc;
    mtk_vdec_framesizes[count_framesizes].stepwise = stepwise_fhd;
    + if (!(ctx->dev->dec_capability & VCODEC_CAPABILITY_4K_DISABLED) &&
    + fourcc != V4L2_PIX_FMT_VP8_FRAME) {
    + mtk_vdec_framesizes[count_framesizes].stepwise.max_width =
    + VCODEC_DEC_4K_CODED_WIDTH;
    + mtk_vdec_framesizes[count_framesizes].stepwise.max_height =
    + VCODEC_DEC_4K_CODED_HEIGHT;
    + }
    num_framesizes++;
    break;
    case V4L2_PIX_FMT_MM21:
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-16 01:56    [W:4.049 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site