lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 0371/1157] media: atmel: atmel-sama7g5-isc: fix warning in configs without OF
    Date
    From: Eugen Hristev <eugen.hristev@microchip.com>

    [ Upstream commit b2bae4b8e637dd751d27918a6b27bd5abcd08859 ]

    All warnings (new ones prefixed by >>):

    >> drivers/media/platform/atmel/atmel-sama7g5-isc.c:610:34: warning: unused variable 'microchip_xisc_of_match' [-Wunused-const-variable]
    static const struct of_device_id microchip_xisc_of_match[] = {
    ^
    13 warnings generated.

    vim +/microchip_xisc_of_match +610 drivers/media/platform/atmel/atmel-sama7g5-isc.c

    609
    > 610 static const struct of_device_id microchip_xisc_of_match[] = {
    611 { .compatible = "microchip,sama7g5-isc" },
    612 { }
    613 };
    614 MODULE_DEVICE_TABLE(of, microchip_xisc_of_match);
    615

    Fixed warning by guarding the atmel_isc_of_match by CONFIG_OF.

    Reported-by: kernel test robot <lkp@intel.com>
    Fixes: c9aa973884a1 ("media: atmel: atmel-isc: add microchip-xisc driver")
    Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/platform/atmel/atmel-sama7g5-isc.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/media/platform/atmel/atmel-sama7g5-isc.c b/drivers/media/platform/atmel/atmel-sama7g5-isc.c
    index 83b175070c06..8b11aa8340d7 100644
    --- a/drivers/media/platform/atmel/atmel-sama7g5-isc.c
    +++ b/drivers/media/platform/atmel/atmel-sama7g5-isc.c
    @@ -591,11 +591,13 @@ static const struct dev_pm_ops microchip_xisc_dev_pm_ops = {
    SET_RUNTIME_PM_OPS(xisc_runtime_suspend, xisc_runtime_resume, NULL)
    };

    +#if IS_ENABLED(CONFIG_OF)
    static const struct of_device_id microchip_xisc_of_match[] = {
    { .compatible = "microchip,sama7g5-isc" },
    { }
    };
    MODULE_DEVICE_TABLE(of, microchip_xisc_of_match);
    +#endif

    static struct platform_driver microchip_xisc_driver = {
    .probe = microchip_xisc_probe,
    --
    2.35.1



    \
     
     \ /
      Last update: 2022-08-16 01:46    [W:2.551 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site