lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 0396/1157] media: amphion: output firmware error message
    Date
    From: Ming Qian <ming.qian@nxp.com>

    [ Upstream commit 89e3f3fb3d9014efa59ed6bb526d5f1a00168452 ]

    Firmware may send the error event with some error message,
    and it help locate the firmware error,
    so output the error message if it exists

    Fixes: 61cbf1c1fa6d7 ("media: amphion: implement vpu core communication based on mailbox")
    Signed-off-by: Ming Qian <ming.qian@nxp.com>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/platform/amphion/vpu_msgs.c | 7 ++++++-
    1 file changed, 6 insertions(+), 1 deletion(-)

    diff --git a/drivers/media/platform/amphion/vpu_msgs.c b/drivers/media/platform/amphion/vpu_msgs.c
    index d5850df8f1d5..d8247f36d84b 100644
    --- a/drivers/media/platform/amphion/vpu_msgs.c
    +++ b/drivers/media/platform/amphion/vpu_msgs.c
    @@ -150,7 +150,12 @@ static void vpu_session_handle_eos(struct vpu_inst *inst, struct vpu_rpc_event *

    static void vpu_session_handle_error(struct vpu_inst *inst, struct vpu_rpc_event *pkt)
    {
    - dev_err(inst->dev, "unsupported stream\n");
    + char *str = (char *)pkt->data;
    +
    + if (strlen(str))
    + dev_err(inst->dev, "instance %d firmware error : %s\n", inst->id, str);
    + else
    + dev_err(inst->dev, "instance %d is unsupported stream\n", inst->id);
    call_void_vop(inst, event_notify, VPU_MSG_ID_UNSUPPORTED, NULL);
    vpu_v4l2_set_error(inst);
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-16 01:43    [W:2.863 / U:0.584 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site