lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 1064/1095] ext4: use kmemdup() to replace kmalloc + memcpy
    Date
    From: Shuqi Zhang <zhangshuqi3@huawei.com>

    [ Upstream commit 4efd9f0d120c55b08852ee5605dbb02a77089a5d ]

    Replace kmalloc + memcpy with kmemdup()

    Signed-off-by: Shuqi Zhang <zhangshuqi3@huawei.com>
    Reviewed-by: Ritesh Harjani <ritesh.list@gmail.com>
    Link: https://lore.kernel.org/r/20220525030120.803330-1-zhangshuqi3@huawei.com
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/ext4/xattr.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
    index b57fd07fbdba..d92d50de5a01 100644
    --- a/fs/ext4/xattr.c
    +++ b/fs/ext4/xattr.c
    @@ -1887,11 +1887,10 @@ ext4_xattr_block_set(handle_t *handle, struct inode *inode,

    unlock_buffer(bs->bh);
    ea_bdebug(bs->bh, "cloning");
    - s->base = kmalloc(bs->bh->b_size, GFP_NOFS);
    + s->base = kmemdup(BHDR(bs->bh), bs->bh->b_size, GFP_NOFS);
    error = -ENOMEM;
    if (s->base == NULL)
    goto cleanup;
    - memcpy(s->base, BHDR(bs->bh), bs->bh->b_size);
    s->first = ENTRY(header(s->base)+1);
    header(s->base)->h_refcount = cpu_to_le32(1);
    s->here = ENTRY(s->base + offset);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-16 01:41    [W:4.024 / U:0.208 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site