lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 0354/1157] crypto: sun8i-ss - fix a NULL vs IS_ERR() check in sun8i_ss_hashkey
    Date
    From: Peng Wu <wupeng58@huawei.com>

    [ Upstream commit 7e8df1fc2d669d04c1f8a9e2d61d7afba1b43df4 ]

    The crypto_alloc_shash() function never returns NULL. It returns error
    pointers.

    Fixes: 801b7d572c0a ("crypto: sun8i-ss - add hmac(sha1)")
    Signed-off-by: Peng Wu <wupeng58@huawei.com>
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c
    index 845019bd9591..36a82b22953c 100644
    --- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c
    +++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c
    @@ -30,8 +30,8 @@ static int sun8i_ss_hashkey(struct sun8i_ss_hash_tfm_ctx *tfmctx, const u8 *key,
    int ret = 0;

    xtfm = crypto_alloc_shash("sha1", 0, CRYPTO_ALG_NEED_FALLBACK);
    - if (!xtfm)
    - return -ENOMEM;
    + if (IS_ERR(xtfm))
    + return PTR_ERR(xtfm);

    len = sizeof(*sdesc) + crypto_shash_descsize(xtfm);
    sdesc = kmalloc(len, GFP_KERNEL);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-16 01:33    [W:3.148 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site