lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 0353/1157] crypto: sun8i-ss - Fix error codes for dma_mapping_error()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 6cb3f9b25c55928b95a02b9ed8e87ed653b3cce8 ]

    If there is a dma_mapping_error() then return negative error codes.
    Currently this code returns success.

    Fixes: 801b7d572c0a ("crypto: sun8i-ss - add hmac(sha1)")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Acked-by: Corentin Labbe <clabbe.montjoie@gmail.com>
    Tested-by: Corentin Labbe <clabbe.montjoie@gmail.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c
    index ac417a6b39e5..845019bd9591 100644
    --- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c
    +++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c
    @@ -586,7 +586,8 @@ int sun8i_ss_hash_run(struct crypto_engine *engine, void *breq)
    rctx->t_dst[k + 1].len = rctx->t_dst[k].len;
    }
    addr_xpad = dma_map_single(ss->dev, tfmctx->ipad, bs, DMA_TO_DEVICE);
    - if (dma_mapping_error(ss->dev, addr_xpad)) {
    + err = dma_mapping_error(ss->dev, addr_xpad);
    + if (err) {
    dev_err(ss->dev, "Fail to create DMA mapping of ipad\n");
    goto err_dma_xpad;
    }
    @@ -612,7 +613,8 @@ int sun8i_ss_hash_run(struct crypto_engine *engine, void *breq)
    goto err_dma_result;
    }
    addr_xpad = dma_map_single(ss->dev, tfmctx->opad, bs, DMA_TO_DEVICE);
    - if (dma_mapping_error(ss->dev, addr_xpad)) {
    + err = dma_mapping_error(ss->dev, addr_xpad);
    + if (err) {
    dev_err(ss->dev, "Fail to create DMA mapping of opad\n");
    goto err_dma_xpad;
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-16 01:33    [W:4.036 / U:1.368 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site