lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 0335/1157] ath11k: Avoid REO CMD failed prints during firmware recovery
    Date
    From: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>

    [ Upstream commit 0ab52b2bd7be8fd49c8ade7703c1faa15359c6c5 ]

    Currently when firmware recovery is in progress, we do not queue REO
    commands to the firmware, instead -ESHUTDOWN will be returned to the
    caller leading to a failure print on the console. The REO command in
    the problem scenario is sent for all tids of a peer in which case we
    will have 16 failure prints on the console for a single peer. For an
    AP usecase, this count would be even higher in a worst case scenario.
    Since these commands are bound to fail during firmware recovery, it
    is better to avoid printing these failures and thereby avoid message
    flooding on the console.

    Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00887-QCAMSLSWPLZ-1

    Fixes: 8ee8d38ca472 ("ath11k: Fix crash during firmware recovery on reo cmd ring access")
    Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
    Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
    Link: https://lore.kernel.org/r/20220602122929.18896-1-quic_mpubbise@quicinc.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/ath/ath11k/dp_rx.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
    index 049774cc158c..b3e133add1ce 100644
    --- a/drivers/net/wireless/ath/ath11k/dp_rx.c
    +++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
    @@ -835,8 +835,9 @@ void ath11k_peer_rx_tid_delete(struct ath11k *ar,
    HAL_REO_CMD_UPDATE_RX_QUEUE, &cmd,
    ath11k_dp_rx_tid_del_func);
    if (ret) {
    - ath11k_err(ar->ab, "failed to send HAL_REO_CMD_UPDATE_RX_QUEUE cmd, tid %d (%d)\n",
    - tid, ret);
    + if (ret != -ESHUTDOWN)
    + ath11k_err(ar->ab, "failed to send HAL_REO_CMD_UPDATE_RX_QUEUE cmd, tid %d (%d)\n",
    + tid, ret);
    dma_unmap_single(ar->ab->dev, rx_tid->paddr, rx_tid->size,
    DMA_BIDIRECTIONAL);
    kfree(rx_tid->vaddr);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-16 01:25    [W:3.113 / U:0.616 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site